Raw log | Switch to full mode | Login

/b/c/b/cast_shell_android/src/build/tree_truth.sh /b/c/b/cast_shell_android/src src in dir /b/rr/tmp0hUlxV/w: allow_subannotations: False base_name: tree truth steps cmd: ['/b/c/b/cast_shell_android/src/build/tree_truth.sh', '/b/c/b/cast_shell_android/src', 'src'] infra_step: False name: tree truth steps nest_level: 0 ok_ret: frozenset([0]) trigger_specs: [] full environment: AWS_CREDENTIAL_FILE: /b/build/site_config/.boto BOTO_CONFIG: /b/build/site_config/.boto BUILDBOT_BLAMELIST: [u'capn@chromium.org'] BUILDBOT_BRANCH: BUILDBOT_BUILDBOTURL: https://build.chromium.org/p/tryserver.chromium.android/ BUILDBOT_BUILDERNAME: cast_shell_android BUILDBOT_BUILDNUMBER: 246579 BUILDBOT_CLOBBER: BUILDBOT_GOT_REVISION: None BUILDBOT_MASTERNAME: tryserver.chromium.android BUILDBOT_REVISION: BUILDBOT_SCHEDULER: None BUILDBOT_SLAVENAME: slave947-c4 CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/c/cipd DISPLAY: :0.0 GIT_USER_AGENT: linux2 git/2.11.0 slave947-c4.c.chromecompute.google.com.internal HOME: /home/chrome-bot INFRA_BUILDBOT_MASTER_CLASS_NAME: TryserverChromiumAndroid INFRA_BUILDBOT_SLAVE_ACTIVE_SUBDIR: INFRA_BUILDBOT_SLAVE_NAME: slave947-c4 LANG: en_US.UTF-8 LOGDOG_COORDINATOR_HOST: luci-logdog.appspot.com LOGDOG_STREAM_PREFIX: bb/tryserver.chromium.android/cast_shell_android/246579 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/build/rr/tmpkcv5ax/butler.sock PAGER: cat PATH: /b/cipd_path_tools:/b/cipd_client:/home/chrome-bot/slavebin:/b/depot_tools:/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin PWD: /b/build/slave/cast_shell_android/build PYTHONIOENCODING: UTF-8 PYTHONPATH: /b/build/site_config:/b/build/scripts:/b/build/scripts/release:/b/build/third_party:/b/build/third_party/google_api_python_client:/b/build/third_party/httplib2/python2:/b/build/third_party/infra_libs:/b/build/third_party/oauth2client:/b/build/third_party/pyasn1:/b/build/third_party/pyasn1-modules:/b/build/third_party/python-rsa:/b/build/third_party/requests_2_10_0:/b/build/third_party/setuptools-0.6c11:/b/build/third_party/site-packages:/b/build/third_party/uritemplate:/b/build_internal/site_config:/b/build_internal/symsrc:/b/build/slave:/b/build/third_party/buildbot_slave_8_4:/b/build/third_party/twisted_10_2: PYTHONUNBUFFERED: 1 TESTING_SLAVENAME: slave947-c4 USER: chrome-bot USERNAME: chrome-bot !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 965189d07248dbb0300f0ba4a9eaae6b51ff3d4d [DevTools] Reset main frame subtree on navigation eostroukhov, Wed Apr 12 11:57:15 2017 -0700 e9b931b5db3e382b208607439ebc22ab0a7e5a68 Reporting: Properly support endpoints with includeSubdomains. juliatuttle, Wed Apr 12 11:51:25 2017 -0700 bc24ac56413d35a83928c20bb3ccb087086b4b44 [MD settings] vertical align left edge of icons and text in ChromeOS People dschuyler, Wed Apr 12 11:45:34 2017 -0700 e5fd122629a18236e1458f79f0785a49ce0ab707 Removes ShellPort::IsRunningInMash() sky, Wed Apr 12 11:43:23 2017 -0700 3980cdc0619f695e7359824c45063912eaa74bd8 UserCloudPolicyManagerChromeOS: drop unused condition tnagel, Wed Apr 12 11:40:25 2017 -0700 10a4fb8f2b125f8fe8d342584e525c31673a5097 add CaptureFullscreen to voice interaction service. muyuanli, Wed Apr 12 11:26:27 2017 -0700 6d45ee2b349374384c3704cee92f1b3f008e4d86 Add strings for ARC's intent picker. djacobo, Wed Apr 12 11:20:22 2017 -0700 424c41bcf197ff82204e25764321f06b12abf051 Removed __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_9_0 checks. eugenebut, Wed Apr 12 11:18:46 2017 -0700 67963cc21231cf7aa06ea60a6f94813d1b1ac3d2 Disable video_decode_accelerator_gl_unittest on the Windows Intel bots. geofflang, Wed Apr 12 11:17:06 2017 -0700 03e0ed84b42ebd642fe7f517b2d8eda18ebb13e3 [MD settings] keep radio button circles circular dschuyler, Wed Apr 12 11:15:24 2017 -0700 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 965189d07248dbb0300f0ba4a9eaae6b51ff3d4d Author: eostroukhov <eostroukhov@chromium.org> Date: Wed Apr 12 11:57:15 2017 -0700 [DevTools] Reset main frame subtree on navigation BUG=710664 Review-Url: https://codereview.chromium.org/2809003007 Cr-Commit-Position: refs/heads/master@{#464098} .../inspector/resources/resources-panel-on-navigation-expected.txt | 5 ----- .../WebKit/Source/devtools/front_end/resources/ResourcesSection.js | 2 -- 2 files changed, 7 deletions(-) commit e9b931b5db3e382b208607439ebc22ab0a7e5a68 Author: juliatuttle <juliatuttle@chromium.org> Date: Wed Apr 12 11:51:25 2017 -0700 Reporting: Properly support endpoints with includeSubdomains. Reporting is a spec for delivering out-of-band reports from various other parts of the browser. See http://wicg.github.io/reporting/ for the spec, or https://goo.gl/pygX5I for details of the planned implementation in Chromium. This modifies the ReportingCache to look for superdomain matches when asked for clients for an origin but no exact origin match is found. BUG=704259 Review-Url: https://codereview.chromium.org/2779983002 Cr-Commit-Position: refs/heads/master@{#464097} net/reporting/reporting_cache.cc | 114 +++++++++++++++++++++++++----- net/reporting/reporting_cache.h | 25 +++++++ net/reporting/reporting_cache_unittest.cc | 104 +++++++++++++++++++++++++++ 3 files changed, 226 insertions(+), 17 deletions(-) commit bc24ac56413d35a83928c20bb3ccb087086b4b44 Author: dschuyler <dschuyler@chromium.org> Date: Wed Apr 12 11:45:34 2017 -0700 [MD settings] vertical align left edge of icons and text in ChromeOS People This CL updates the vertical alignment of items on multiples of 60px (the old style was to line up on multiples of 56px). BUG=710704, 709654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2815783002 Cr-Commit-Position: refs/heads/master@{#464096} .../resources/settings/people_page/user_list.html | 2 +- .../resources/settings/people_page/users_page.html | 33 +++++++++------------- 2 files changed, 14 insertions(+), 21 deletions(-) commit e5fd122629a18236e1458f79f0785a49ce0ab707 Author: sky <sky@chromium.org> Date: Wed Apr 12 11:43:23 2017 -0700 Removes ShellPort::IsRunningInMash() And converts to usage of Shell::GetAshConfig(). BUG=687660 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2815043002 Cr-Commit-Position: refs/heads/master@{#464095} .../accelerator_controller_unittest.cc | 13 +++++----- ash/accelerators/accelerator_filter_unittest.cc | 8 +++--- ash/aura/shell_port_classic.cc | 6 +---- ash/aura/shell_port_classic.h | 1 - ash/autoclick/autoclick_unittest.cc | 3 ++- .../display_configuration_controller_unittest.cc | 4 +-- ash/laser/laser_pointer_controller_unittest.cc | 6 ++--- ...desktop_task_switch_metric_recorder_unittest.cc | 10 ++++---- ash/metrics/user_metrics_recorder_unittest.cc | 3 ++- ash/mus/bridge/shell_port_mash.cc | 4 --- ash/mus/bridge/shell_port_mash.h | 1 - ash/root_window_controller.cc | 8 +++--- ash/root_window_controller_unittest.cc | 13 +++++----- ash/rotator/screen_rotation_animator_unittest.cc | 17 ++++++------ ash/screen_util_unittest.cc | 4 +-- ...shelf_button_pressed_metric_tracker_unittest.cc | 13 +++++----- ash/shelf/shelf_layout_manager_unittest.cc | 21 +++++++-------- ash/shelf/shelf_tooltip_manager_unittest.cc | 7 ++--- ash/shelf/shelf_view_unittest.cc | 15 ++++++----- ash/shelf/shelf_window_watcher.cc | 3 ++- ash/shelf/shelf_window_watcher_unittest.cc | 13 +++++----- ash/shelf/wm_shelf.cc | 8 +++--- ash/shell.cc | 30 +++++++++++----------- ash/shell_port.h | 3 --- ash/shell_unittest.cc | 5 ++-- ash/sticky_keys/sticky_keys_overlay_unittest.cc | 5 ++-- ash/system/ime/tray_ime_chromeos_unittest.cc | 6 ++--- .../overview/overview_button_tray_unittest.cc | 5 ++-- ash/system/power/power_event_observer.cc | 5 ++-- ash/system/toast/toast_manager_unittest.cc | 7 ++--- .../ash_popup_alignment_delegate_unittest.cc | 6 ++--- .../web_notification_tray_unittest.cc | 4 +-- ash/test/ash_test.cc | 3 ++- ash/test/ash_test_base.cc | 2 +- ash/tooltips/tooltip_controller_unittest.cc | 4 +-- ash/wallpaper/wallpaper_controller_unittest.cc | 3 ++- ash/wm/immersive_fullscreen_controller_unittest.cc | 24 ++++++++--------- ash/wm/lock_state_controller_unittest.cc | 14 +++++----- .../maximize_mode_window_manager_unittest.cc | 9 ++++--- ash/wm/overview/window_selector_unittest.cc | 18 ++++++------- ash/wm/panels/panel_layout_manager_unittest.cc | 16 ++++++------ ash/wm/panels/panel_window_resizer_unittest.cc | 21 +++++++-------- ash/wm/system_modal_container_layout_manager.cc | 3 ++- ...stem_modal_container_layout_manager_unittest.cc | 11 ++++---- ash/wm/toplevel_window_event_handler_unittest.cc | 4 +-- ash/wm/window_cycle_controller_unittest.cc | 10 ++++---- ash/wm/window_manager_unittest.cc | 12 ++++----- .../workspace/workspace_event_handler_unittest.cc | 10 ++++---- .../workspace/workspace_layout_manager_unittest.cc | 5 ++-- .../workspace/workspace_window_resizer_unittest.cc | 6 ++--- ash/wm_window.cc | 10 ++++---- 51 files changed, 226 insertions(+), 216 deletions(-) commit 3980cdc0619f695e7359824c45063912eaa74bd8 Author: tnagel <tnagel@chromium.org> Date: Wed Apr 12 11:40:25 2017 -0700 UserCloudPolicyManagerChromeOS: drop unused condition wait_for_policy_fetch_ can never be false in OnBlockinFetchTimeout() since it being true is the precondition for the timer to be started, and when it's set to false, the timer is stopped as well. BUG=none Review-Url: https://codereview.chromium.org/2811103005 Cr-Commit-Position: refs/heads/master@{#464094} chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 10a4fb8f2b125f8fe8d342584e525c31673a5097 Author: muyuanli <muyuanli@chromium.org> Date: Wed Apr 12 11:26:27 2017 -0700 add CaptureFullscreen to voice interaction service. BUG=b/35643583 TEST=Fullscreen screenshot is sent to voice interaction session. Review-Url: https://codereview.chromium.org/2811143003 Cr-Commit-Position: refs/heads/master@{#464093} .../arc_voice_interaction_framework_service.cc | 14 ++++++++++++++ .../arc_voice_interaction_framework_service.h | 1 + components/arc/common/voice_interaction_framework.mojom | 5 ++++- 3 files changed, 19 insertions(+), 1 deletion(-) commit 6d45ee2b349374384c3704cee92f1b3f008e4d86 Author: djacobo <djacobo@chromium.org> Date: Wed Apr 12 11:20:22 2017 -0700 Add strings for ARC's intent picker. Add new strings for the intent picker bubble. BUG=678141 TEST=Strings still not in use, so only flashed the device. Review-Url: https://codereview.chromium.org/2613773002 Cr-Commit-Position: refs/heads/master@{#464092} chrome/app/generated_resources.grd | 9 +++++++++ 1 file changed, 9 insertions(+) commit 424c41bcf197ff82204e25764321f06b12abf051 Author: eugenebut <eugenebut@chromium.org> Date: Wed Apr 12 11:18:46 2017 -0700 Removed __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_9_0 checks. BUG=None Review-Url: https://codereview.chromium.org/2804803003 Cr-Commit-Position: refs/heads/master@{#464091} ios/chrome/browser/autofill/form_input_accessory_view_controller.mm | 2 -- ios/chrome/browser/ui/keyboard/UIKeyCommand+Chrome.mm | 5 +---- ios/web/public/web_state/ui/crw_web_view_proxy.h | 5 +---- 3 files changed, 2 insertions(+), 10 deletions(-) commit 67963cc21231cf7aa06ea60a6f94813d1b1ac3d2 Author: geofflang <geofflang@chromium.org> Date: Wed Apr 12 11:17:06 2017 -0700 Disable video_decode_accelerator_gl_unittest on the Windows Intel bots. These bots are unable to start the test due to missing OpenGL extensions. TBR=kbr@chromium.org NOTRY=true BUG=angleproject:1144 BUG=710628 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2814103002 Cr-Commit-Position: refs/heads/master@{#464090} content/test/gpu/generate_buildbot_json.py | 9 +++++++ testing/buildbot/chromium.gpu.fyi.json | 38 ------------------------------ 2 files changed, 9 insertions(+), 38 deletions(-) commit 03e0ed84b42ebd642fe7f517b2d8eda18ebb13e3 Author: dschuyler <dschuyler@chromium.org> Date: Wed Apr 12 11:15:24 2017 -0700 [MD settings] keep radio button circles circular This CL prevents the 'circle part' of a radio button from 'flex shrinking' when the label for the button gets too big (creating a kind of pressure on the radio button). BUG=705479 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2809123004 Cr-Commit-Position: refs/heads/master@{#464089} chrome/browser/resources/settings/settings_shared_css.html | 3 +++ 1 file changed, 3 insertions(+) commit 4b16553ab1201a9830dc46e01892f9ea21eb3ef9 Author: csashi <csashi@google.com> Date: Wed Apr 12 11:12:48 2017 -0700 Fixes accessibility navigation out of Autofill popup. We post a delayed callback to clear accessibility focus. If we receive a focus event, we cancel the delayed callback. At the end of the video below, we can see the accessibility focus moving out of the popup and to the next HTML element, which is "Address:" https://drive.google.com/a/google.com/file/d/0B-jTnU8uuAL9NzNUMGNzMXVYUUE/view?usp=sharing BUG=627860 Review-Url: https://codereview.chromium.org/2811803002 Cr-Commit-Position: refs/heads/master@{#464088} .../chromium/android_webview/AwAutofillClient.java | 3 ++ .../autofill/AutofillKeyboardAccessoryBridge.java | 3 ++ .../browser/autofill/AutofillPopupBridge.java | 7 ++++ .../chrome/browser/autofill/AutofillTest.java | 4 +++ .../components/autofill/AutofillDelegate.java | 6 ++++ .../components/autofill/AutofillPopup.java | 32 +++++++++++++++++ .../browser_accessibility_manager_android.cc | 42 +++++++++++++++++----- .../browser_accessibility_manager_android.h | 3 ++ .../accessibility/BrowserAccessibilityManager.java | 15 ++++++-- 9 files changed, 104 insertions(+), 11 deletions(-) commit 2d54317a97881484713af4069f01677e924dc87e Author: chili <chili@chromium.org> Date: Wed Apr 12 11:10:55 2017 -0700 [Offline pages] Add new Error page failure status inside the MHTML archiver and update corresponding histogram. This should record number of error pages we are seeing being recorded by Prerender and also eliminate this altogether. BUG=709639,692688 Review-Url: https://codereview.chromium.org/2810913002 Cr-Commit-Position: refs/heads/master@{#464087} .../offline_pages/offline_page_mhtml_archiver.cc | 20 ++++++++++++ .../offline_pages/offline_page_mhtml_archiver.h | 4 +++ .../offline_page_mhtml_archiver_unittest.cc | 36 ++++++++++++++++++++++ .../offline_pages/core/offline_page_archiver.h | 2 ++ .../offline_pages/core/offline_page_model_impl.cc | 5 +++ components/offline_pages/core/offline_page_types.h | 4 +++ tools/metrics/histograms/histograms.xml | 2 ++ 7 files changed, 73 insertions(+) commit 5f418b53fdc5b34cf7a1b8b2fa7dc99ff5d7624d Author: nednguyen <nednguyen@google.com> Date: Wed Apr 12 13:05:58 2017 -0400 Manually roll src/third_party/catapult/ 6e6baa037..f57871dac (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6e6baa037e67..f57871dac2cd $ git log 6e6baa037..f57871dac --date=short --no-merges --format='%ad %ae %s' 2017-04-12 nednguyen Make sure that trace are captured in results even when story run fails This also includes change to smoothness.py due to the API changes in story_test Created with: roll-dep src/third_party/catapult BUG=704488 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I864583b63f7978ad3161c61fca826a3d4cd9c586 Reviewed-on: https://chromium-review.googlesource.com/475132 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#464086} DEPS | 2 +- tools/perf/measurements/smoothness.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) commit f6d9d3d52ed411f5c39948cbb48969f1ccf41192 Author: dpapad <dpapad@chromium.org> Date: Wed Apr 12 11:08:04 2017 -0700 MD Settings: Restore focus after exiting Content settings sub-subpages,. BUG=709586 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2813033004 Cr-Commit-Position: refs/heads/master@{#464085} .../settings/privacy_page/privacy_page.html | 3 +- .../settings_page/settings_animated_pages.js | 9 +++- .../site_settings_page/site_settings_page.html | 55 ++++++++++++---------- .../site_settings_page/site_settings_page.js | 48 +++++++++++++++++++ 4 files changed, 87 insertions(+), 28 deletions(-) commit 8588407dac066cab5eac58b342b9ebd4f75bc848 Author: Asanka Herath <asanka@chromium.org> Date: Wed Apr 12 12:28:44 2017 -0400 [downloads] Move platform specific code out of DownloadTargetDeterminer. This CL cleans up the download target determination logic so that: * DownloadTargetDeterminer provides a reason for requesting user confirmation for a download path. The caller can thus use platform specific logic to handle the confirmation request. Chromium on Android doesn't always prompt the user for a download location, and hence needs to know *why* a confirmation is requested in order to decide how to proceed. * DownloadTargetDeterminer allows the caller to return a finer grained result than a boolean following a confirmation request. Just knowing whether the user confirmed or rejected is insufficient. On Android, for example, there are cases where the platform specific code will automatically accept a confirmation request raised by the DownloadTargetDeterminer. In such cases, it is important to note whether the result indicates explicit user consent or not, which is a signal used elsewhere for determining download security. * DownloadPathReservationTracker provides a detailed result after completing target determination. The extra detail allows DownloadTargetDeterminer to indicate *why* the target determination failed rather than just the fact that it failed. This result can then be translated to an interrupt reason. Consequently, the download target conflict resolution logic can now be moved entirely into ChromeDownloadManagerDelegate. Previously the logic was split between DownloadTargetDeterminer, DownloadPathReservationTracker, and ChromeDownloadManagerDelegate on Android. BUG=334474 Change-Id: Id3e40bcb4653f259dab1ae96645c230a2a45e06c Reviewed-on: https://chromium-review.googlesource.com/465566 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#464084} chrome/browser/BUILD.gn | 3 + .../chrome_duplicate_download_infobar_delegate.cc | 18 +- .../chrome_duplicate_download_infobar_delegate.h | 6 +- .../download/chrome_download_manager_delegate.cc | 87 +- .../download/chrome_download_manager_delegate.h | 20 +- .../chrome_download_manager_delegate_unittest.cc | 374 ++++++-- chrome/browser/download/download_browsertest.cc | 30 +- .../download/download_confirmation_reason.h | 36 + .../download/download_confirmation_result.h | 28 + chrome/browser/download/download_file_picker.cc | 14 +- chrome/browser/download/download_file_picker.h | 12 +- .../download/download_path_reservation_tracker.cc | 219 +++-- .../download/download_path_reservation_tracker.h | 15 +- .../download_path_reservation_tracker_unittest.cc | 309 +++--- .../browser/download/download_target_determiner.cc | 239 +++-- .../browser/download/download_target_determiner.h | 52 +- .../download/download_target_determiner_delegate.h | 30 +- .../download_target_determiner_unittest.cc | 1011 +++++++++++--------- chrome/browser/download/download_target_info.cc | 16 + chrome/browser/download/download_target_info.h | 8 + .../download_test_file_activity_observer.cc | 16 +- 21 files changed, 1530 insertions(+), 1013 deletions(-) commit bd1f17f86efd1346e16628622ddde56d560d4a4b Author: fmeawad <fmeawad@chromium.org> Date: Wed Apr 12 11:05:24 2017 -0700 [Memory UMA] Return a memory summary struck with the ack message This CL updates the returned mojo message to include the MemoryDumpCallbackResult. That struct will be used to create a memory summary that can be sent through UMA and used for other purposes. A follow up CL will add the extra_processes_dump map. BUG=703184 Review-Url: https://codereview.chromium.org/2777093009 Cr-Commit-Position: refs/heads/master@{#464083} base/trace_event/memory_dump_manager.cc | 24 ++++--- base/trace_event/memory_dump_manager.h | 15 +++-- base/trace_event/memory_dump_manager_unittest.cc | 75 ++++++++++++++-------- base/trace_event/memory_dump_request_args.cc | 3 + base/trace_event/memory_dump_request_args.h | 12 +++- .../browser/tracing/memory_tracing_browsertest.cc | 9 +-- .../memory/coordinator/coordinator_impl.cc | 12 ++-- .../memory/coordinator/coordinator_impl.h | 4 +- .../coordinator/coordinator_impl_unittest.cc | 3 +- .../memory/memory_dump_manager_delegate_impl.cc | 4 +- .../cpp/memory/memory_dump_manager_delegate_impl.h | 4 +- .../cpp/memory/memory_instrumentation.typemap | 3 + .../memory/memory_instrumentation_struct_traits.cc | 34 ++++++++++ .../memory/memory_instrumentation_struct_traits.h | 53 +++++++++++++++ .../interfaces/memory/memory_instrumentation.mojom | 21 +++++- 15 files changed, 213 insertions(+), 63 deletions(-) commit 7c5d4db1a21cb156b3881bf67233e3004bf17852 Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org> Date: Wed Apr 12 17:02:49 2017 +0000 Roll src/third_party/pdfium/ 12c74ac6e..445831ebc (1 commit) https://pdfium.googlesource.com/pdfium.git/+log/12c74ac6ee2d..445831ebcec3 $ git log 12c74ac6e..445831ebc --date=short --no-merges --format='%ad %ae %s' 2017-04-11 dsinclair Remove the FGAS Buffered Stream Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Id4dfedd880f9c867c9652cdcea5ed8c250f5dfe6 Reviewed-on: https://chromium-review.googlesource.com/475094 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#464082} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d4a75996a93114e8b6af4a28849c0f4db43347e1 Author: guidou <guidou@chromium.org> Date: Wed Apr 12 10:58:20 2017 -0700 Reland of Enable spec-compliant algorithm for MediaStream video constraints by default (patchset #1 id:1 of https://codereview.chromium.org/2810913007/ ) Reason for revert: The fix for the issue has landed. Original issue's description: > Revert of Enable spec-compliant algorithm for MediaStream video constraints by default (patchset #2 id:40001 of https://codereview.chromium.org/2793053002/ ) > > Reason for revert: > Regressed performance_browser_tests 21-93% (see crbug.com/710187). Suspect that chrome.tabCapture extension API is providing constraints in the legacy format, and this feature switch is causing bad defaults to be used instead. > > > Original issue's description: > > Enable spec-compliant algorithm for MediaStream video constraints by default > > > > BUG=657733 > > > > Review-Url: https://codereview.chromium.org/2793053002 > > Cr-Commit-Position: refs/heads/master@{#462575} > > Committed: https://chromium.googlesource.com/chromium/src/+/73d1c7107a41b474c6fed9292ff41f7ce3429a42 > > TBR=avi@chromium.org,stkhapugin@chromium.org,guidou@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=657733 > > Review-Url: https://codereview.chromium.org/2810913007 > Cr-Commit-Position: refs/heads/master@{#463913} > Committed: https://chromium.googlesource.com/chromium/src/+/8f48e5edcd8494a2b8ec8e45c49eecf7039feb08 TBR=avi@chromium.org,stkhapugin@chromium.org,miu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657733 Review-Url: https://codereview.chromium.org/2814813004 Cr-Commit-Position: refs/heads/master@{#464081} content/public/common/content_features.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a2d733fbc1be5a976181e17de5021c997dcb711e Author: dtrainor <dtrainor@chromium.org> Date: Wed Apr 12 10:56:36 2017 -0700 Fix open paths for download ContentId work Add two new ways to open an OfflineItem in the new API path: - From the snackbar. - From the notification. BUG=691805 Review-Url: https://codereview.chromium.org/2798093003 Cr-Commit-Position: refs/heads/master@{#464080} .../download/DownloadNotificationService.java | 2 ++ .../download/DownloadSnackbarController.java | 28 ++++++++++++++-------- ...flineContentAggregatorNotificationBridgeUi.java | 5 ++++ 3 files changed, 25 insertions(+), 10 deletions(-) commit 0ecaeb804b4aab2c9aad6953954705499d2ad4a1 Author: awdf <awdf@chromium.org> Date: Wed Apr 12 10:54:56 2017 -0700 [Android O] Split out browser notification channels - Incognito, Media, and Download notifications are all now posted to their own special channels, which are created on startup. - The Browser channel remains for all other misc browser notifications. BUG=704978 Review-Url: https://codereview.chromium.org/2814603003 Cr-Commit-Position: refs/heads/master@{#464079} .../download/DownloadNotificationService.java | 4 +- .../incognito/IncognitoNotificationManager.java | 2 +- .../media/MediaCaptureNotificationService.java | 2 +- .../browser/media/ui/MediaNotificationManager.java | 2 +- .../browser/notifications/ChannelsInitializer.java | 18 +++++- .../java/strings/android_chrome_strings.grd | 9 +++ .../notifications/ChannelsInitializerTest.java | 69 +++++++++++++++++++++- .../browser/notifications/ChannelsUpdaterTest.java | 10 +++- 8 files changed, 106 insertions(+), 10 deletions(-) commit e4b2c606f4fcdfc6d535165bef73bf9d0a9eb157 Author: cjgrant <cjgrant@chromium.org> Date: Wed Apr 12 10:53:12 2017 -0700 VR: Add a native UI element scene manager - Mirror the concept of the HTML scene manager in native. - Temporarily let both the HTML UI and native code manage elements. - Future CLs will supply native-driven WebVR security warnings. BUG=710150 Review-Url: https://codereview.chromium.org/2809143004 Cr-Commit-Position: refs/heads/master@{#464078} chrome/browser/android/vr_shell/BUILD.gn | 2 + .../browser/android/vr_shell/ui_scene_manager.cc | 53 ++++++++++++++++++++++ chrome/browser/android/vr_shell/ui_scene_manager.h | 41 +++++++++++++++++ chrome/browser/android/vr_shell/vr_gl_thread.cc | 9 +++- chrome/browser/android/vr_shell/vr_gl_thread.h | 8 ++++ chrome/browser/android/vr_shell/vr_shell.cc | 10 +++- chrome/browser/android/vr_shell/vr_shell_gl.cc | 12 ++--- chrome/browser/android/vr_shell/vr_shell_gl.h | 11 ++--- 8 files changed, 126 insertions(+), 20 deletions(-) commit 95feea54d56c15f1c3a0b4fc73cfc3579d3e8220 Author: scottmg <scottmg@chromium.org> Date: Wed Apr 12 10:51:33 2017 -0700 network service: Handle redirects in nav, and fix some bindings setup - No need for refcounted class - Hang on to the client ptr so that the connection isn't dropped - Handle redirects (google.com -> google.com/?some-stuff). Now gets as far as OnStartLoadingResponseBody() with a valid consumer pipe handle. - unique_ptr(new ...) -> base::MakeUnique BUG=598073 TEST=manual run of content_shell --enable-browser-side-navigation --enable-network-service Review-Url: https://codereview.chromium.org/2817523003 Cr-Commit-Position: refs/heads/master@{#464077} content/browser/loader/navigation_url_loader.cc | 14 ++++++------ .../navigation_url_loader_network_service.cc | 25 ++++++++++++++++------ .../loader/navigation_url_loader_network_service.h | 12 ++++------- 3 files changed, 30 insertions(+), 21 deletions(-) commit 4624411ae3f604ce2e6ff453be42cf7e61b6ca30 Author: bratell <bratell@opera.com> Date: Wed Apr 12 10:49:58 2017 -0700 Avoid duplicate functions/code in core/inspector: isErrorStatusCode While experimenting with unity builds I encountered a few duplicate symbols and functions in core/inspector. One of them was isErrorStatusCode, a one instruction function that was defined in both NetworkResourcesData.cpp and InspectorNetworkAgent.cpp. This patch renames one of them IsHTTPErrorStatusCode, a more suitable name. Review-Url: https://codereview.chromium.org/2807533005 Cr-Commit-Position: refs/heads/master@{#464076} third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 89906c83686ebc2e0e7add6b9fb5d0e04b4d2e7a Author: rsesek <rsesek@chromium.org> Date: Wed Apr 12 10:48:20 2017 -0700 [Mac] Block updates to the History menu when it is open. This prevents favicons from flickering during session restore. BUG=496862 Review-Url: https://codereview.chromium.org/2817543002 Cr-Commit-Position: refs/heads/master@{#464075} chrome/browser/ui/cocoa/history_menu_bridge.h | 8 ++++++++ chrome/browser/ui/cocoa/history_menu_bridge.mm | 14 +++++++++++++- chrome/browser/ui/cocoa/history_menu_cocoa_controller.h | 2 +- chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm | 10 ++++++++++ 4 files changed, 32 insertions(+), 2 deletions(-) commit fd4907914a01400c06a0954123e169769ceb101c Author: rogerm <rogerm@chromium.org> Date: Wed Apr 12 10:46:41 2017 -0700 [autofill] Log UPI-VPA usage as an Autofill.UserHappiness metric. UPI-VPA = Universal Payments Interface - Virtual Payment Addresss http://www.npci.org.in/UPI_Background.aspx This CL - Adds a function identify UPI Virtual Payment Address strings - Adds a UPI-VPA value to Autofill.UserHappiness - Logs observations of UPI-VPAs while evaluating field prediction quality. BUG=702220 Review-Url: https://codereview.chromium.org/2805313002 Cr-Commit-Position: refs/heads/master@{#464074} .../autofill/core/browser/autofill_metrics.h | 4 ++ .../core/browser/autofill_metrics_unittest.cc | 41 +++++++++++++++++++ .../core/browser/autofill_regex_constants.cc | 29 ++++++++++++++ .../core/browser/autofill_regex_constants.h | 6 +++ components/autofill/core/browser/form_structure.cc | 5 +++ components/autofill/core/browser/validation.cc | 5 +++ components/autofill/core/browser/validation.h | 4 ++ .../autofill/core/browser/validation_unittest.cc | 46 ++++++++++++++++++++++ 8 files changed, 140 insertions(+) commit 76d0929033d6cd3ec36b96d1b4845166e70c9349 Author: yigu <yigu@chromium.org> Date: Wed Apr 12 10:44:53 2017 -0700 Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager Due to crbug.com/701355, all style related main thread scrolling reasons stop being recorded. This patch moves the logic of storing the style related reasons to PLSA and move the recording logic to ScrollManager because the information on the compositor side is insufficient. The disabled test due to the previous bug has been enabled again with minor modification. BUG=704805 TEST=All/NonCompositedMainThreadScrollingReasonTest.*; EventHandlerTest.NonCompositedMainThreadScrollingReason* CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2773593005 Cr-Commit-Position: refs/heads/master@{#464073} cc/input/main_thread_scrolling_reason.h | 32 ++- third_party/WebKit/Source/core/frame/FrameView.cpp | 31 +-- third_party/WebKit/Source/core/frame/FrameView.h | 8 - .../WebKit/Source/core/input/EventHandlerTest.cpp | 233 +++++++++++++++++++++ .../WebKit/Source/core/input/ScrollManager.cpp | 64 ++++++ .../WebKit/Source/core/input/ScrollManager.h | 3 + .../Source/core/paint/PaintLayerScrollableArea.cpp | 67 ++---- .../Source/core/paint/PaintLayerScrollableArea.h | 10 +- .../Source/web/tests/ScrollingCoordinatorTest.cpp | 164 ++++++++++----- .../Source/web/tests/data/two_scrollable_area.html | 4 + ui/events/blink/input_handler_proxy.cc | 4 + 11 files changed, 452 insertions(+), 168 deletions(-) commit 6051193a1a2f5d7ad673326ba398324ad4975841 Author: glebl <glebl@chromium.org> Date: Wed Apr 12 10:43:11 2017 -0700 Move container_builder to NGLayoutAlgorithm base class. BUG=635619 Review-Url: https://codereview.chromium.org/2810833003 Cr-Commit-Position: refs/heads/master@{#464072} .../layout/ng/inline/ng_inline_layout_algorithm.cc | 1 - .../layout/ng/inline/ng_inline_layout_algorithm.h | 1 - .../core/layout/ng/ng_block_layout_algorithm.cc | 92 +++++++++++----------- .../core/layout/ng/ng_block_layout_algorithm.h | 2 - .../layout/ng/ng_block_layout_algorithm_test.cc | 2 + .../Source/core/layout/ng/ng_layout_algorithm.h | 13 ++- 6 files changed, 60 insertions(+), 51 deletions(-) commit d850820a384d5cad1cbbcdfc209becdaf6beae88 Author: pdr <pdr@chromium.org> Date: Wed Apr 12 10:41:27 2017 -0700 Make linux_layout_tests_slimming_paint_v2 run with dcheck_always_on This patch updates the slimming paint v2 trybot to run with dcheck_always_on. BUG=702805 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2816613002 Cr-Commit-Position: refs/heads/master@{#464071} .../WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 | 2 ++ tools/mb/mb_config.pyl | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) commit 91b3f7e7b1f592052614ffd6eb61d60f87dd2571 Author: kaznacheev <kaznacheev@chromium.org> Date: Wed Apr 12 10:35:23 2017 -0700 Support region selection for voice interaction session Introducing two new ways to invoke a voice interaction session for a specific region: 1. If kEnableVoiceInteraction is enabled, the "Capture region" stylus tool does not take a screenshot but starts a voice interaction session for that region. 2. Shift+Search+A invokes the "metalayer" - an alternative region selection tool. BUG=b:37165189 TEST="Capture region" stylus tool start voice Interaction session. Shift+Search+A invokes the "metalayer". Review-Url: https://codereview.chromium.org/2803403002 Cr-Commit-Position: refs/heads/master@{#464070} .../arc_voice_interaction_framework_service.cc | 27 ++++++++--- chrome/browser/ui/ash/palette_delegate_chromeos.cc | 55 ++++++++++++++++++++-- chrome/browser/ui/ash/palette_delegate_chromeos.h | 7 +++ .../arc/common/voice_interaction_framework.mojom | 13 ++++- 4 files changed, 91 insertions(+), 11 deletions(-) commit 8ce1b3a5c77dbe359a1592acb9bcfbadf3339bf0 Author: donnd <donnd@chromium.org> Date: Wed Apr 12 10:33:46 2017 -0700 Revert of [Reland] Use dropdown list for admin areas in pr form. (patchset #2 id:40001 of https://codereview.chromium.org/2812893002/ ) Reason for revert: Still some lingering test failures. See crbug.com/710911 Original issue's description: > Reland explanation: crrev.com/2680143002 caused chrome_public_test_apk > failing on chromium.android/Marshmallow. The problem is fixed in this > CL. > > To make the payment request tests independent of the network status, > the tests set the time-out = 0, > which means that the sub-keys must never be fetched, > and the address forms will always show a textfield, > and not a dropdown for the admin areas. > > In the previous CL, the time-out would start after the request. > => For some entities (with network connection), > subkeys were already fetched, before the timeout had started. > => A dropdown would show. > > To solve this, the order was changed. > Now the time-out starts before the request. > > > BUG=709491 > > Review-Url: https://codereview.chromium.org/2812893002 > Cr-Commit-Position: refs/heads/master@{#463945} > Committed: https://chromium.googlesource.com/chromium/src/+/886089f3cad28e46fa21e3d73c60fd5e87d7621f TBR=mathp@chromium.org,sebsg@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,parastoog@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=709491 Review-Url: https://codereview.chromium.org/2817733002 Cr-Commit-Position: refs/heads/master@{#464069} .../browser/autofill/PersonalDataManager.java | 67 +------ .../chrome/browser/payments/AddressEditor.java | 219 ++++++--------------- .../browser/payments/PaymentRequestImpl.java | 4 +- .../browser/payments/ui/EditorDropdownField.java | 11 +- .../browser/payments/ui/EditorFieldModel.java | 13 +- .../chrome/browser/payments/ui/EditorView.java | 6 +- .../autofill/AutofillProfileBridge.java | 23 +-- .../browser/autofill/AutofillTestHelper.java | 2 +- .../android/personal_data_manager_android.cc | 101 +--------- .../android/personal_data_manager_android.h | 54 +---- components/payments/core/address_normalizer.cc | 7 +- components/payments/core/address_normalizer.h | 4 +- .../chromium/chrome_address_validator.cc | 18 +- .../chromium/chrome_address_validator.h | 11 +- .../chromium/chrome_address_validator_unittest.cc | 35 +--- 15 files changed, 96 insertions(+), 479 deletions(-) commit 02fcf46036643c6c896c059161f2a2b6aa8e6c6b Author: guidou <guidou@chromium.org> Date: Wed Apr 12 10:31:14 2017 -0700 Update constraints algorithm for screen capture. If explicit frame rate is given, use that as default. This is more compatible with existing tests and applications and is still spec compliant. This fixes a regression. Use media::limits::kMaxDimension/2 (16383) as maximum screencast dimension. The older value could produce results that exceed the maximum canvas size, which is 16384 x 16384 - 1. Properly use explicit maximum dimensions and frame rate as default in screen capture. An older fix for dimensions had a bug when the maximum allowed values coincided with explicitly given max constraints. BUG=657733,710187 Review-Url: https://codereview.chromium.org/2814063002 Cr-Commit-Position: refs/heads/master@{#464068} .../media_stream_constraints_util_video_content.cc | 174 ++++++++++++++------- .../media_stream_constraints_util_video_content.h | 7 +- ...ream_constraints_util_video_content_unittest.cc | 156 +++++++++++++----- 3 files changed, 238 insertions(+), 99 deletions(-) commit e8b8728db9d39906383b4699ed9e6b397b992cea Author: jbroman <jbroman@chromium.org> Date: Wed Apr 12 10:29:39 2017 -0700 TemplateURL: Check that search term prefix and suffix do not overlap. BUG=710766 Review-Url: https://codereview.chromium.org/2814113002 Cr-Commit-Position: refs/heads/master@{#464067} components/search_engines/template_url.cc | 4 +++- components/search_engines/template_url_unittest.cc | 8 ++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) commit e49774a1cca97ac55ee4f9af730cc36cb4b79015 Author: dtseng <dtseng@chromium.org> Date: Wed Apr 12 10:27:56 2017 -0700 Switch to selected 8-dot braille table in email and url text fields BUG=707933 TEST=verify manually email and url type inputs have 8-dot i/o. Verify that switching away from these fields reverts back to user selected table. OutputE2ETest revision for automation. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2813743002 Cr-Commit-Position: refs/heads/master@{#464066} .../braille/braille_translator_manager.js | 38 +++++++++------------- .../braille/braille_translator_manager_test.extjs | 7 ++-- .../chromevox/chromevox/background/background.js | 2 +- .../chromevox/chromevox/background/options.js | 6 ++-- .../chromevox/cvox2/background/background.js | 3 ++ .../chromevox/cvox2/background/chromevox_state.js | 28 +++++++++++++++- .../chromeos/chromevox/cvox2/background/editing.js | 32 ++++++++++++++++++ .../chromevox/cvox2/background/output_test.extjs | 2 +- .../chromevox/host/chrome/braille_background.js | 1 + .../chromevox/strings/chromevox_strings.grd | 8 ++--- .../browser/ui/views/omnibox/omnibox_view_views.cc | 1 + 11 files changed, 92 insertions(+), 36 deletions(-) commit dc448150e1780b9158ecce7cf8ee153a8f9f61cf Author: pnoland <pnoland@chromium.org> Date: Wed Apr 12 10:26:07 2017 -0700 reland of [sync] Fix decryption failure caused by missing user_key Recently, a change removed code that populated the user_key field of nigori nodes. Clients running code from before this change fail to import keys that don't have user_key populated. If a post-change client commits a nigori node, a pre-change client will fail to subsequently import it. This change restores code that populates user_key, but omits code that fails the import if the user_key is absent. The original issue this patch was trying to address was a mismatch between what clients of different versions expected; v1 expected a user_key to exist, but v2 didn't set one. When v1 read a key created by v2, it failed. The original patch(v3) created a new mismatch of expectations; v3 implicitly expected a user_key to exist when exporting. This caused a similar problem; v3 crashed when exporting a key created by v2. The reland only exports the user_key when it's present. R=pavely@chromium.org BUG=707967 Review-Url: https://codereview.chromium.org/2809233002 Cr-Commit-Position: refs/heads/master@{#464065} components/sync/base/cryptographer.cc | 18 +++++++----- components/sync/base/nigori.cc | 19 +++++++++++-- components/sync/base/nigori.h | 13 +++++++-- components/sync/base/nigori_unittest.cc | 32 ++++++++++++++++++++-- .../sync/engine_impl/model_type_worker_unittest.cc | 3 +- 5 files changed, 70 insertions(+), 15 deletions(-) commit c6494e265fc1de5c751198a4282daf7e5c30eb10 Author: hiroshige <hiroshige@chromium.org> Date: Wed Apr 12 10:24:27 2017 -0700 Rename Script() returning UScriptCode to GetScript() To avoid naming conflict between Script() and a new class Script that will be introduced by https://codereview.chromium.org/2780463002/. BUG=686281 Review-Url: https://codereview.chromium.org/2815523002 Cr-Commit-Position: refs/heads/master@{#464064} third_party/WebKit/Source/core/css/CSSFontSelector.cpp | 2 +- .../WebKit/Source/core/layout/ng/inline/ng_inline_node.h | 2 +- .../layout/ng/inline/ng_layout_inline_items_builder.cc | 2 +- .../WebKit/Source/core/paint/InlineTextBoxPainter.cpp | 2 +- third_party/WebKit/Source/platform/LayoutLocale.cpp | 4 ++-- third_party/WebKit/Source/platform/LayoutLocale.h | 4 ++-- third_party/WebKit/Source/platform/LayoutLocaleTest.cpp | 16 +++++++++------- .../platform/fonts/AcceptLanguagesResolverTest.cpp | 2 +- .../WebKit/Source/platform/fonts/FontDescription.h | 2 +- .../Source/platform/fonts/android/FontCacheAndroid.cpp | 2 +- .../platform/fonts/android/FontCacheAndroidTest.cpp | 2 +- .../platform/fonts/shaping/CachingWordShaperTest.cpp | 2 +- .../WebKit/Source/platform/fonts/win/FontFallbackWin.cpp | 4 ++-- 13 files changed, 24 insertions(+), 22 deletions(-) commit c3af64f7f18be7630bdec9e879a2eb457464c591 Author: creis <creis@chromium.org> Date: Wed Apr 12 10:22:38 2017 -0700 Update about:flags description of --site-per-process flag. This was originally described in terms of OOPIFs as an experimental feature, but OOPIFs have now launched. The new description better describes what the --site-per-process mode enables. BUG=467770 TEST=No behavior change Review-Url: https://codereview.chromium.org/2813873003 Cr-Commit-Position: refs/heads/master@{#464063} chrome/browser/flag_descriptions.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 753494c7f71f9a82c63440f47140e475df7e8771 Author: gogerald <gogerald@chromium.org> Date: Wed Apr 12 10:15:34 2017 -0700 Add web app manifest section table in SQLite web database The table has three columns: {'id', 'min_version', 'fingerprints'}. The table has no primary key. This table is used to reduce payment app's loading time in payment request, refer below doc for details. https://docs.google.com/a/google.com/document/d/1Ncsp96Ae5836NLOdPwHRzcX3zkgj-4-5fq_nI2azC7M/edit?usp=sharing BUG=708508 Review-Url: https://codereview.chromium.org/2801513002 Cr-Commit-Position: refs/heads/master@{#464062} components/BUILD.gn | 1 + components/payments/android/BUILD.gn | 29 ++++ components/payments/android/DEPS | 5 + .../android/web_app_manifest_section_table.cc | 146 +++++++++++++++++++++ .../android/web_app_manifest_section_table.h | 57 ++++++++ .../web_app_manifest_section_table_unittest.cc | 138 +++++++++++++++++++ components/webdata_services/BUILD.gn | 4 + components/webdata_services/DEPS | 1 + .../webdata_services/web_data_service_wrapper.cc | 16 ++- 9 files changed, 393 insertions(+), 4 deletions(-) commit 3804c15d9dd121b800391b7467e5e53223d8373c Author: Ken Rockot <rockot@chromium.org> Date: Tue Apr 11 19:03:40 2017 -0700 Add debugging CHECKs for data pipe serialization crash It seems that somehow a data pipe consumer handle is losing its internal shared buffer and this is crashing Mojo loading. This CL adds some temporary CHECKs to attempt to pinpoint where things are going wrong. BUG=706689,659195 R=yzshen@chromium.org Change-Id: I46d42a49ab233a1b7cacf5cd91fc57db0338ab1c Reviewed-on: https://chromium-review.googlesource.com/474175 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#464061} mojo/edk/embedder/platform_shared_buffer.cc | 20 ++++++++++++++++++-- mojo/edk/js/tests/js_to_cpp_tests.js | 8 -------- mojo/edk/system/data_pipe_consumer_dispatcher.cc | 17 +++++++++++++++++ 3 files changed, 35 insertions(+), 10 deletions(-) commit 2296abe71f34c79cc7ef1c01b22fc9e11283e457 Author: v8-autoroll <v8-autoroll@chromium.org> Date: Wed Apr 12 10:13:49 2017 -0700 Update V8 to version 5.9.214.1 (cherry-pick). Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/90043159..05d62e61 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2817513003 Cr-Commit-Position: refs/heads/master@{#464060} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bcba287825394261983a99443cb1be450de1083c Author: siggi <siggi@chromium.org> Date: Wed Apr 12 10:07:54 2017 -0700 Update Crashpad to 1f28a123a4c9449e3d7ddad4ff00dacd366d5216 46f403377367 posix: Add ScopedDIR for managing open directories ab9c03f8827b win: Promote WinMultiProcessWithTempDir to test/win for reuse 9c6d190b9570 linux: Add ScopedPtraceAttach to manage ptrace attachments fd9f952393ea Fix crashpad_util_test build with GCC after 4b450c813795 e142aa87d663 linux: Fix crashpad_util_test ScopedPtraceAttach.* with the Yama LSM a5d81370beda linux: Use pread64() instead of pread() in ProcessMemory 30385d4e4772 handler: Add user extensibility stream call-out 79425e4d9737 win: Free an old buffer before attempting to allocate a resized one 1f28a123a4c9 designdoc: Add description of user data sources BUG=crashpad:167,crashpad:30 Review-Url: https://codereview.chromium.org/2814043003 Cr-Commit-Position: refs/heads/master@{#464059} .../third_party/crashpad/crashpad/handler/BUILD.gn | 2 + .../third_party/crashpad/crashpad/util/BUILD.gn | 2 + .../content/app/run_as_crashpad_handler_win.cc | 2 +- third_party/crashpad/README.chromium | 2 +- third_party/crashpad/crashpad/build/run_tests.py | 5 + .../crashpad/client/crashpad_client_win_test.cc | 194 +------------------- .../crashpad/crashpad/compat/android/linux/prctl.h | 25 +++ third_party/crashpad/crashpad/crashpad.gyp | 1 + .../crashpad/crashpad/doc/overview_design.md | 14 ++ .../crashpad/handler/crashpad_handler_test.cc | 132 +++++++++++++ .../crashpad_handler_test_extended_handler.cc | 70 +++++++ third_party/crashpad/crashpad/handler/handler.gyp | 2 + .../crashpad/crashpad/handler/handler_main.cc | 10 +- .../crashpad/crashpad/handler/handler_main.h | 11 +- .../crashpad/crashpad/handler/handler_test.gyp | 64 +++++++ .../handler/mac/crash_report_exception_handler.cc | 11 +- .../handler/mac/crash_report_exception_handler.h | 5 +- third_party/crashpad/crashpad/handler/main.cc | 12 +- .../crashpad/handler/user_stream_data_source.cc | 43 +++++ .../crashpad/handler/user_stream_data_source.h | 68 +++++++ .../handler/win/crash_report_exception_handler.cc | 11 +- .../handler/win/crash_report_exception_handler.h | 5 +- .../crashpad/minidump/minidump_file_writer.cc | 5 +- .../crashpad/minidump/minidump_file_writer_test.cc | 40 +++- .../crashpad/crashpad/minidump/minidump_test.gyp | 43 +++-- .../minidump_user_extension_stream_data_source.cc | 8 +- .../minidump_user_extension_stream_data_source.h | 51 ++++-- .../minidump/minidump_user_stream_writer.cc | 40 ++-- .../minidump/minidump_user_stream_writer.h | 15 +- .../minidump/minidump_user_stream_writer_test.cc | 14 +- .../test/minidump_user_extension_stream_util.cc | 43 +++++ .../test/minidump_user_extension_stream_util.h | 53 ++++++ .../crashpad/snapshot/win/process_reader_win.cc | 13 +- .../crashpad/crashpad/test/scoped_temp_dir_test.cc | 6 +- third_party/crashpad/crashpad/test/test.gyp | 2 + .../test/win/win_multiprocess_with_temp_dir.cc | 188 +++++++++++++++++++ .../test/win/win_multiprocess_with_temp_dir.h | 80 ++++++++ .../crashpad/crashpad/util/linux/process_memory.cc | 9 +- .../crashpad/util/linux/scoped_ptrace_attach.cc | 62 +++++++ .../crashpad/util/linux/scoped_ptrace_attach.h | 52 ++++++ .../util/linux/scoped_ptrace_attach_test.cc | 204 +++++++++++++++++++++ .../crashpad/crashpad/util/posix/close_multiple.cc | 14 +- .../crashpad/util/posix/process_info_linux.cc | 28 +-- .../crashpad/crashpad/util/posix/scoped_dir.cc | 30 +++ .../crashpad/crashpad/util/posix/scoped_dir.h | 38 ++++ third_party/crashpad/crashpad/util/util.gyp | 4 + third_party/crashpad/crashpad/util/util_test.gyp | 1 + .../crashpad/crashpad/util/win/process_info.cc | 5 + 48 files changed, 1422 insertions(+), 317 deletions(-) commit d02c080f54d8aca7e1827374177c17f4ad68a593 Author: donnd <donnd@chromium.org> Date: Wed Apr 12 10:04:34 2017 -0700 Revert of Reimplement AccountManagerHelper singleton instance creation (patchset #4 id:180001 of https://codereview.chromium.org/2747293005/ ) Reason for revert: Caused multiple bot failures, see crbug.com/710901. Original issue's description: > Reimplement AccountManagerHelper singleton instance creation > > Current implementation of AccountManagerHelper can instantiate wrong delegate > type if get() is called in too early. This CL fixes it. AtomicReference is used > to avoid relying on external synchronization, because get() can be called > from different threads. This CL also adds > AccountManagerHelper.resetAccountManagerHelperForTests method that makes sure > there's no interference between tests. > > BUG=698258 > > Review-Url: https://codereview.chromium.org/2747293005 > Cr-Commit-Position: refs/heads/master@{#463963} > Committed: https://chromium.googlesource.com/chromium/src/+/1305003fecaca059c4e3a5678eb48f0a00a46317 TBR=rogerta@chromium.org,nyquist@chromium.org,bsazonov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=698258 Review-Url: https://codereview.chromium.org/2817723002 Cr-Commit-Position: refs/heads/master@{#464058} .../browser/history/HistoryActivityTest.java | 1 - .../preferences/PasswordViewingTypeTest.java | 6 ---- .../privacy/ClearBrowsingDataPreferencesTest.java | 1 - .../signin/OAuth2TokenServiceIntegrationTest.java | 7 ++-- .../browser/signin/OAuth2TokenServiceTest.java | 6 ---- .../chrome/browser/signin/SigninHelperTest.java | 6 ---- .../chromium/chrome/browser/signin/SigninTest.java | 3 -- .../SupervisedUserContentProviderTest.java | 1 - .../browser/sync/ui/PassphraseActivityTest.java | 1 - .../chrome/browser/util/FeatureUtilitiesTest.java | 6 ---- .../invalidation/InvalidationControllerTest.java | 11 ------ .../SupervisedUserContentProviderUnitTest.java | 4 --- .../chromium/chrome/browser/sync/SyncTestBase.java | 1 - .../test/util/browser/signin/SigninTestUtil.java | 8 ----- .../browser/account_tracker_service_unittest.cc | 3 -- .../components/signin/AccountManagerHelper.java | 42 +++++++++++----------- .../components/signin/ChildAccountInfoFetcher.java | 7 ---- .../signin/test/AccountManagerHelperTest.java | 6 ---- .../core/browser/child_account_info_fetcher.cc | 6 ---- .../core/browser/child_account_info_fetcher.h | 2 -- .../browser/child_account_info_fetcher_android.cc | 5 --- .../browser/child_account_info_fetcher_android.h | 2 -- .../components/sync/AndroidSyncSettingsTest.java | 6 ---- 23 files changed, 22 insertions(+), 119 deletions(-) commit e9c64a91ffa876438944769b5921d171b5390cc8 Author: mcasas <mcasas@chromium.org> Date: Wed Apr 12 10:00:27 2017 -0700 Media Capabilities: add MediaDecodingConfiguration.idl and update to Spec This CL shuffles around the idl data structures to match the current Spec status, namely: - gets MediaType and |type| out of MediaConfiguration(.idl) - adds them to a new file MediaDecodingConfiguration(.idl), as MediaDecodingType |type|. MediaDecodingConfiguration derives from MediaConfiguration. LayoutTests updated accordingly. BUG=709181, 690380 Review-Url: https://codereview.chromium.org/2813133002 Cr-Commit-Position: refs/heads/master@{#464057} .../wpt/media-capabilities/idlharness-expected.txt | 3 ++- .../external/wpt/media-capabilities/idlharness.html | 15 +++++++++++---- .../modules/media_capabilities/MediaCapabilities.cpp | 12 ++++++------ .../modules/media_capabilities/MediaCapabilities.h | 4 ++-- .../modules/media_capabilities/MediaCapabilities.idl | 4 +++- .../modules/media_capabilities/MediaConfiguration.idl | 7 ------- .../media_capabilities/MediaDecodingConfiguration.idl | 16 ++++++++++++++++ third_party/WebKit/Source/modules/modules_idl_files.gni | 3 +++ 8 files changed, 43 insertions(+), 21 deletions(-) commit d2d9a34e2fd74fd45026a8fed6f4715de18df747 Author: adithyas <adithyas@chromium.org> Date: Wed Apr 12 09:54:28 2017 -0700 Move ScriptState::GetExecutionContext (Part 5) This CL replaces all uses of ScriptState::GetExecutionContext in Source/modules with ExecutionContext::From. BUG=682322 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2816543002 Cr-Commit-Position: refs/heads/master@{#464056} .../app_banner/BeforeInstallPromptEvent.cpp | 5 +-- .../Source/modules/battery/BatteryManager.cpp | 5 +-- .../Source/modules/battery/NavigatorBattery.cpp | 7 ++-- .../Source/modules/beacon/NavigatorBeacon.cpp | 2 +- .../WebKit/Source/modules/bluetooth/Bluetooth.cpp | 2 +- .../WebKit/Source/modules/budget/BudgetService.cpp | 11 +++--- .../Source/modules/cachestorage/CacheStorage.cpp | 3 +- .../Source/modules/cachestorage/CacheTest.cpp | 3 +- .../modules/canvas2d/BaseRenderingContext2D.cpp | 5 +-- .../CompositorWorkerGlobalScope.cpp | 3 +- .../credentialmanager/CredentialsContainer.cpp | 24 ++++++------- .../Source/modules/crypto/CryptoResultImpl.cpp | 2 +- .../WebKit/Source/modules/crypto/SubtleCrypto.cpp | 42 ++++++++++++---------- .../Source/modules/csspaint/CSSPaintDefinition.cpp | 3 +- .../modules/encryptedmedia/MediaKeySession.cpp | 5 +-- .../NavigatorRequestMediaKeySystemAccess.cpp | 3 +- third_party/WebKit/Source/modules/fetch/Body.cpp | 9 ++--- .../Source/modules/fetch/BodyStreamBuffer.cpp | 11 +++--- .../WebKit/Source/modules/fetch/FetchManager.cpp | 3 +- .../Source/modules/fetch/FetchRequestData.cpp | 8 +++-- .../WebKit/Source/modules/fetch/Request.cpp | 21 +++++------ .../WebKit/Source/modules/fetch/Response.cpp | 15 ++++---- .../WebKit/Source/modules/fetch/ResponseTest.cpp | 3 +- .../filesystem/DataTransferItemFileSystem.cpp | 3 +- .../WebKit/Source/modules/filesystem/Entry.cpp | 15 ++++---- .../filesystem/HTMLInputElementFileSystem.cpp | 3 +- .../WebKit/Source/modules/indexeddb/IDBFactory.cpp | 33 ++++++++--------- .../WebKit/Source/modules/indexeddb/IDBIndex.cpp | 10 +++--- .../Source/modules/indexeddb/IDBKeyRange.cpp | 13 +++---- .../Source/modules/indexeddb/IDBObjectStore.cpp | 20 +++++------ .../WebKit/Source/modules/indexeddb/IDBRequest.cpp | 2 +- .../Source/modules/indexeddb/IDBTransaction.cpp | 2 +- .../modules/indexeddb/InspectorIndexedDBAgent.cpp | 6 ++-- .../modules/installedapp/NavigatorInstalledApp.cpp | 3 +- .../Source/modules/mediasession/MediaMetadata.cpp | 3 +- .../modules/mediasession/NavigatorMediaSession.cpp | 3 +- .../Source/modules/mediasource/URLMediaSource.cpp | 3 +- .../Source/modules/mediastream/MediaDevices.cpp | 5 +-- .../Source/modules/mediastream/MediaStream.cpp | 2 +- .../modules/mediastream/MediaStreamTrack.cpp | 2 +- .../Source/modules/mediastream/URLMediaStream.cpp | 3 +- .../netinfo/WorkerNavigatorNetworkInformation.cpp | 3 +- third_party/WebKit/Source/modules/nfc/NFC.cpp | 5 +-- .../Source/modules/notifications/Notification.cpp | 4 +-- .../modules/notifications/NotificationManager.cpp | 2 +- .../ServiceWorkerRegistrationNotifications.cpp | 2 +- .../offscreencanvas/OffscreenCanvasModules.cpp | 3 +- .../OffscreenCanvasRenderingContext2D.cpp | 7 ++-- .../modules/peerconnection/RTCPeerConnection.cpp | 28 +++++++-------- .../Source/modules/permissions/Permissions.cpp | 17 ++++----- .../modules/presentation/PresentationReceiver.cpp | 3 +- .../modules/presentation/PresentationRequest.cpp | 2 +- .../Source/modules/push_messaging/PushManager.cpp | 8 ++--- .../modules/quota/DeprecatedStorageQuota.cpp | 4 +-- .../WebKit/Source/modules/quota/StorageManager.cpp | 15 ++++---- .../Source/modules/serviceworkers/FetchEvent.cpp | 7 ++-- .../Source/modules/serviceworkers/InstallEvent.cpp | 3 +- .../serviceworkers/NavigatorServiceWorker.cpp | 5 +-- .../modules/serviceworkers/ServiceWorker.cpp | 3 +- .../modules/serviceworkers/ServiceWorkerClient.cpp | 3 +- .../serviceworkers/ServiceWorkerClients.cpp | 9 ++--- .../serviceworkers/ServiceWorkerContainer.cpp | 6 ++-- .../serviceworkers/ServiceWorkerGlobalScope.cpp | 3 +- .../serviceworkers/ServiceWorkerWindowClient.cpp | 9 ++--- .../modules/shapedetection/ShapeDetector.cpp | 3 +- .../modules/speech/DOMWindowSpeechSynthesis.cpp | 3 +- .../WebKit/Source/modules/speech/SpeechGrammar.cpp | 3 +- .../Source/modules/speech/SpeechGrammarList.cpp | 3 +- .../WebKit/Source/modules/vr/NavigatorVR.cpp | 3 +- third_party/WebKit/Source/modules/vr/VRDisplay.cpp | 5 +-- .../modules/webaudio/AudioWorkletGlobalScope.cpp | 2 +- .../modules/webgl/WebGLRenderingContextBase.cpp | 9 ++--- .../modules/webmidi/MIDIAccessInitializer.cpp | 3 +- .../Source/modules/webmidi/NavigatorWebMIDI.cpp | 3 +- .../Source/modules/webshare/NavigatorShare.cpp | 5 +-- 75 files changed, 290 insertions(+), 229 deletions(-) commit 69985211bfe655c40d6c651bb8b38e813e728594 Author: scottmg <scottmg@chromium.org> Date: Wed Apr 12 09:47:28 2017 -0700 Beginnings of PlzNavigate navigation using URLLoader in network service Instead getting ResourceDispatcherHostImpl to start the request, this is the beginning of using the network service's URLLoader to do the navigation request. BUG=598073 TEST=manual run of content_shell --enable-browser-side-navigation --enable-network-service Review-Url: https://codereview.chromium.org/2812853004 Cr-Commit-Position: refs/heads/master@{#464055} content/browser/BUILD.gn | 2 + content/browser/loader/navigation_url_loader.cc | 20 ++++- .../navigation_url_loader_network_service.cc | 86 ++++++++++++++++++++++ .../loader/navigation_url_loader_network_service.h | 79 ++++++++++++++++++++ .../public/app/mojo/content_browser_manifest.json | 1 + 5 files changed, 184 insertions(+), 4 deletions(-) commit a25783c221c34f889678d96b8c119c976b0bb45a Author: bratell <bratell@opera.com> Date: Wed Apr 12 09:41:27 2017 -0700 Deduplicating compositing scrollingCoordinator helper In the experiments with unity builds I ran into the scrollingCoordinatorFromLayer function that was defined identically at two different places. This patch moves the code to PaintLayer where it is also available to PaintLayer itself. R=pdr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2803013005 Cr-Commit-Position: refs/heads/master@{#464054} .../core/layout/compositing/CompositedLayerMapping.cpp | 17 +++++------------ .../layout/compositing/CompositingLayerAssigner.cpp | 7 +------ third_party/WebKit/Source/core/paint/PaintLayer.cpp | 10 +++++++--- third_party/WebKit/Source/core/paint/PaintLayer.h | 4 ++++ 4 files changed, 17 insertions(+), 21 deletions(-) commit 65c4eb23fd50e9e5199e8ab0fab8f652b69e277e Author: stkhapugin <stkhapugin@chromium.org> Date: Wed Apr 12 09:35:29 2017 -0700 [ObjC ARC] Converts ios/chrome/browser/ui/downloads:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2676653003 Cr-Commit-Position: refs/heads/master@{#464053} ios/chrome/browser/ui/downloads/BUILD.gn | 1 + .../ui/downloads/download_manager_controller_unittest.mm | 14 ++++++++------ 2 files changed, 9 insertions(+), 6 deletions(-) commit fe3f46f92f93b06b429c51439cbb846d42c0521f Author: kbr <kbr@chromium.org> Date: Wed Apr 12 09:28:49 2017 -0700 Revert of Fix broken draw/upload paths from videos to 2D canvas and WebGL. (patchset #13 id:230001 of https://codereview.chromium.org/2791813003/ ) Reason for revert: Broke conformance/extensions/oes-texture-float-with-video.html on Android with NVIDIA GPUs: http://crbug.com/710874 . Original issue's description: > Fix broken draw/upload paths from videos to 2D canvas and WebGL. > > The fix for Issue 672895 made these video rendering and upload paths > fragile if the video's metadata caused the natural size to differ in > certain ways from the coded size. Make the code robust to this case by > reverting to CopyTextureCHROMIUM in most cases, and allocating the > texture to the correct sizes in others. > > Tested with new WebGL conformance test to be incorporated in a > forthcoming roll: https://github.com/KhronosGroup/WebGL/pull/2359 . > > BUG=701060 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2791813003 > Cr-Commit-Position: refs/heads/master@{#463925} > Committed: https://chromium.googlesource.com/chromium/src/+/0cc4c62a163318c06636916b7e2b2c6a56f16b74 TBR=dalecurtis@chromium.org,dglazkov@chromium.org,liberato@chromium.org,sandersd@chromium.org,tobiasjs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=701060 Review-Url: https://codereview.chromium.org/2818493002 Cr-Commit-Position: refs/heads/master@{#464052} content/renderer/media/webmediaplayer_ms.cc | 6 +- content/renderer/media/webmediaplayer_ms.h | 3 - .../gpu_tests/webgl2_conformance_expectations.py | 4 + .../gpu_tests/webgl_conformance_expectations.py | 4 + media/blink/webmediaplayer_impl.cc | 6 +- media/blink/webmediaplayer_impl.h | 3 - media/renderers/skcanvas_video_renderer.cc | 109 +++++---------------- media/renderers/skcanvas_video_renderer.h | 21 ++-- .../WebKit/Source/core/html/HTMLVideoElement.cpp | 5 +- .../WebKit/Source/core/html/HTMLVideoElement.h | 4 +- .../modules/webgl/WebGLRenderingContextBase.cpp | 40 +++----- .../modules/webgl/WebGLRenderingContextBase.h | 2 +- .../WebKit/public/platform/WebMediaPlayer.h | 13 ++- 13 files changed, 65 insertions(+), 155 deletions(-) commit 3f03a9bc2664344b6ee326f7540db022bbb4952f Author: lazyboy <lazyboy@chromium.org> Date: Wed Apr 12 09:25:43 2017 -0700 Make all ComplexFeatures with single feature to be SimpleFeature. Change DCHECK in ComplexFeature to ensure it has > 1 features. BUG=710718 Test=Compile & run chrome. Review-Url: https://codereview.chromium.org/2813073003 Cr-Commit-Position: refs/heads/master@{#464051} .../extensions/api/_permission_features.json | 8 ++-- extensions/common/api/_permission_features.json | 48 ++++++++++------------ extensions/common/features/complex_feature.cc | 2 +- 3 files changed, 27 insertions(+), 31 deletions(-) commit 7ed11ddd4311e1e7a4dcd7169d9e24be52c15ed4 Author: miguelg <miguelg@chromium.org> Date: Wed Apr 12 09:23:09 2017 -0700 Add support for progress native notifications The progress indicator is now part of the title BUG=571056 Review-Url: https://codereview.chromium.org/2813903004 Cr-Commit-Position: refs/heads/master@{#464050} .../notification_platform_bridge_mac.mm | 14 +++++++++++- .../notification_platform_bridge_mac_unittest.mm | 25 ++++++++++++++++++++++ 2 files changed, 38 insertions(+), 1 deletion(-) commit a6ec61f4ff79b4e69c7afa4abf92f6be2ddbaada Author: jochen <jochen@chromium.org> Date: Wed Apr 12 09:14:53 2017 -0700 Correct typo in HTMLMediaElement log messages and make it less spammy R=mlamouri@chromium.org BUG=710893 Review-Url: https://codereview.chromium.org/2810213002 Cr-Commit-Position: refs/heads/master@{#464049} third_party/WebKit/Source/core/html/HTMLMediaElement.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 4dc789d8af7d937c03e26b6ffd4a8b874e18fe49 Author: edchin <edchin@chromium.org> Date: Wed Apr 12 09:13:17 2017 -0700 [ios] Rename RootCoordinator to ChromeRootCoordinator. BUG= Review-Url: https://codereview.chromium.org/2810163002 Cr-Commit-Position: refs/heads/master@{#464048} ios/chrome/app/safe_mode/safe_mode_coordinator.h | 4 ++-- ios/chrome/browser/BUILD.gn | 4 ++-- .../browser/{root_coordinator.h => chrome_root_coordinator.h} | 8 ++++---- .../browser/{root_coordinator.mm => chrome_root_coordinator.mm} | 9 ++------- ios/chrome/browser/ui/main/main_coordinator.h | 4 ++-- 5 files changed, 12 insertions(+), 17 deletions(-) commit 11ef2243282ba965699d0ee9ec4e71c9c66070c7 Author: avayvod <avayvod@chromium.org> Date: Wed Apr 12 09:11:36 2017 -0700 [Cast, Android] Add try/catch guard around Cast session info building. Due to a bug in Google Play Services, Cast.CastApi methods can throw exceptions even if the api client appears to be connected. This change adds a try/catch guard around the block using these methods to prevent Chrome from crashing. BUG=708964 TEST=manual Review-Url: https://codereview.chromium.org/2814853003 Cr-Commit-Position: refs/heads/master@{#464047} .../browser/media/router/cast/CastSessionImpl.java | 73 ++++++++++++---------- 1 file changed, 41 insertions(+), 32 deletions(-) commit 6ab36201c67153ba617a6a9817e22bc3d303f927 Author: liaoyuke <liaoyuke@chromium.org> Date: Wed Apr 12 09:10:07 2017 -0700 Implement request mobile site. This CL implements the "Request Mobile Site" functionality to enable switching from the desktop version of a page to mobile version. BUG=678047 Review-Url: https://codereview.chromium.org/2789433006 Cr-Commit-Position: refs/heads/master@{#464046} ios/chrome/browser/tabs/BUILD.gn | 2 + ios/chrome/browser/tabs/tab.h | 8 +- ios/chrome/browser/tabs/tab.mm | 49 +++- ios/chrome/browser/ui/browser_view_controller.mm | 21 +- ios/chrome/browser/ui/tools_menu/BUILD.gn | 1 + .../request_desktop_mobile_site_egtest.mm | 293 +++++++++++++++++++++ .../ui/tools_menu/tools_menu_configuration.h | 6 +- .../browser/ui/tools_menu/tools_menu_model.h | 2 +- .../browser/ui/tools_menu/tools_menu_model.mm | 17 +- .../ui/tools_menu/tools_menu_view_controller.mm | 10 - .../tools_menu_view_controller_unittest.mm | 12 +- .../ui/tools_menu/tools_popup_menu_egtest.mm | 97 +------ ios/testing/BUILD.gn | 2 +- ...op_test_page.html => user_agent_test_page.html} | 2 +- 14 files changed, 356 insertions(+), 166 deletions(-) commit 828b2c40768e30aba718697edc4fe1f1c10e9b8a Author: shess <shess@chromium.org> Date: Wed Apr 12 09:08:21 2017 -0700 [sql] Remove SQL parsing from InMemoryURLIndexTest. Previously this code used an ad-hoc system to load and execute SQL statements from a golden file. Change the golden files to contain only SQL comments, and load using Execute(). Additionally, modify the time-adjustment code to do a bulk SQL change rather than running queries through the history sub-system. BUG=137352 Review-Url: https://codereview.chromium.org/2790583003 Cr-Commit-Position: refs/heads/master@{#464045} components/omnibox/browser/BUILD.gn | 4 +- .../browser/in_memory_url_index_unittest.cc | 97 ++++-------- ...ex_test.db.txt => in_memory_url_index_test.sql} | 162 ++++++++++----------- ...db.txt => in_memory_url_index_test_limited.sql} | 4 +- 4 files changed, 112 insertions(+), 155 deletions(-) commit 8dde8b9785f55333f5905a248bfc715e23aff244 Author: liaoyuke <liaoyuke@chromium.org> Date: Wed Apr 12 09:06:34 2017 -0700 [iOS] Re-factoring FormsTestCase. This CL re-factors FormsTestCase by doing the following things: 1. Add necessary wait condition after form submission and resend warning dialog confirmation to make the tests more robust. 2. Remove private helper methods that can be replaced by public helpers. 3. De-couple redirect test from other tests so that other tests do not need to depend on TestFormRedirectResponseProvider. BUG= Review-Url: https://codereview.chromium.org/2807323002 Cr-Commit-Position: refs/heads/master@{#464044} ios/chrome/browser/web/forms_egtest.mm | 360 ++++++++++++-------------- ios/chrome/test/earl_grey/BUILD.gn | 1 + ios/chrome/test/earl_grey/chrome_earl_grey.h | 11 + ios/chrome/test/earl_grey/chrome_earl_grey.mm | 24 ++ 4 files changed, 208 insertions(+), 188 deletions(-) commit b40e86cfe3be375f082767f2836d5a2ff6b4912b Author: tkent <tkent@chromium.org> Date: Wed Apr 12 09:02:54 2017 -0700 Fix attribute matching logic to follow the DOM standard. The old logic: If a name is given and the element is an HTMLElement in an HTML document, we search existing attributes for the name with case-insensitive matching. The correct logic: If a name is given and the element is an HTMLElement in an HTML document, we search existing attributes for a lowercased name. There are some ways to add an attribute with a name including uppercased letters to an HTMLElement. Such attribute should not be found by name search. Also, if a namespace and a local name are given, we should not do case-insensitive matching at all. Thew new behavior matches to the DOM standard, Firefox, and Safari. * fast/dom/Element/setAttributeNode-case-insensitivity.html This test fails with this CL. Upstreaming a part of it to WPT, and removing it. BUG=502301 Review-Url: https://codereview.chromium.org/2814443008 Cr-Commit-Position: refs/heads/master@{#464043} .../external/wpt/dom/nodes/attributes-expected.txt | 8 +-- .../external/wpt/dom/nodes/attributes.html | 24 +++++++++ ...etAttributeNode-case-insensitivity-expected.txt | 21 -------- .../setAttributeNode-case-insensitivity.html | 61 ---------------------- .../WebKit/Source/core/dom/AttributeCollection.h | 44 ++++++---------- third_party/WebKit/Source/core/dom/Element.cpp | 36 ++++++------- third_party/WebKit/Source/core/dom/Element.h | 6 ++- .../WebKit/Source/core/dom/NamedNodeMap.cpp | 4 +- third_party/WebKit/Source/core/dom/QualifiedName.h | 8 --- .../WebKit/Source/platform/wtf/text/WTFString.h | 6 --- 10 files changed, 67 insertions(+), 151 deletions(-) commit 5a78808161cff2557d53f9278d1b93bcc2495f47 Author: martijn <martijn@martijnc.be> Date: Wed Apr 12 08:58:38 2017 -0700 Improve json_comment_eater.py performance. The JSON check in PRESUBMIT.py used to take ~3 minutes to complete on a large JSON file (e.g.: net/http/transport_security_state_static.h). This CL brings that down to a couple of seconds. Profiling showed that most time was lost in the string.find() call in _FindNextToken(). Old: Presubmit checks took 206.2s to calculate. New: Presubmit checks took 3.6s to calculate. BUG=697716 Review-Url: https://codereview.chromium.org/2797253011 Cr-Commit-Position: refs/heads/master@{#464042} tools/json_comment_eater/json_comment_eater.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) commit dae7b95e366ce877d08585a7b73927f96fe65d88 Author: gmanikpure <gmanikpure@chromium.org> Date: Wed Apr 12 08:57:00 2017 -0700 [Chromedriver] Disable tests involving alert dialog on webview_shell. BUG= Review-Url: https://codereview.chromium.org/2811243002 Cr-Commit-Position: refs/heads/master@{#464041} chrome/test/chromedriver/test/run_py_tests.py | 3 +++ 1 file changed, 3 insertions(+) commit fb1afab382a5636b6959ebb0db8529657292cb50 Author: nicholss <nicholss@chromium.org> Date: Wed Apr 12 08:52:46 2017 -0700 Fixing unused keychainError var for release builds. R=joedow@chromium.org Review-Url: https://codereview.chromium.org/2817513004 Cr-Commit-Position: refs/heads/master@{#464040} remoting/client/ios/host_preferences.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3a3243c913d98568a9b0edb4018ad3275ae2a8f0 Author: tommycli <tommycli@chromium.org> Date: Wed Apr 12 08:45:29 2017 -0700 [HBD] Tighten-up which adobe.com/go links are intercepted as Flash URLs BUG=709292 Review-Url: https://codereview.chromium.org/2811903002 Cr-Commit-Position: refs/heads/master@{#464039} .../browser/plugins/flash_download_interception.cc | 21 ++++++++++++++++----- .../plugins/flash_download_interception_unittest.cc | 10 ++++++++-- 2 files changed, 24 insertions(+), 7 deletions(-) commit 08f24841310c677a67f79f89253d971820069da4 Author: scroggo <scroggo@chromium.org> Date: Wed Apr 12 08:43:08 2017 -0700 Add a web platform test for APNG While animated-png.html uses internals for selecting frames and verifying that we decode APNGs properly, this test confirms that a basic animation will work correctly, and can work in other browsers. - apng.png A simple APNG with two frames. The first frame is red, and displays for as short a time as possible (11 ms; anything less than that and Chromium increases the time), followed by a green frame. The image does not loop. The green frame matches green.png, which already exists - animated-png-timeout-ref.html Reference page showing the existing image (green.png). BUG=437662 Review-Url: https://codereview.chromium.org/2814453004 Cr-Commit-Position: refs/heads/master@{#464038} .../external/wpt/apng/animated-png-timeout-ref.html | 1 + .../external/wpt/apng/animated-png-timeout.html | 11 +++++++++++ .../WebKit/LayoutTests/external/wpt/images/apng.png | Bin 0 -> 259 bytes 3 files changed, 12 insertions(+) commit c1d98a208cadc9b2ee92a82f641f026f1df9490d Author: fs <fs@opera.com> Date: Wed Apr 12 08:41:10 2017 -0700 Invalidate the "values cache" when resetting animated value state When we revalidate the animated value, and the value 'source' is the 'values' attribute, we need to also reset the cached 'from' and 'to' values kept in SVGAnimationElement. If not, a target change could clear the animated from/to values and not notice that they are stale on revalidation. Companion to https://codereview.chromium.org/2763283002. BUG=710247 Review-Url: https://codereview.chromium.org/2817643003 Cr-Commit-Position: refs/heads/master@{#464037} .../target-move-values-crash-expected.txt | 1 + .../svg/animations/target-move-values-crash.html | 25 ++++++++++++++++++++++ .../WebKit/Source/core/svg/SVGAnimateElement.cpp | 1 + .../WebKit/Source/core/svg/SVGAnimationElement.cpp | 8 +++++-- .../WebKit/Source/core/svg/SVGAnimationElement.h | 1 + 5 files changed, 34 insertions(+), 2 deletions(-) commit 02dc9f2819cf895bc4ec0dd2a67a90435c58f1bc Author: awdf <awdf@chromium.org> Date: Wed Apr 12 08:38:39 2017 -0700 [Android O] Initialize channels on first launch/upgrade - Previously channels would only be created lazily, when a notification was posted to them. - Now they are initialized on first launch (asynchronously) and on app upgrade, so they appear in OS Settings much sooner. - Further work is still required to re-initialize channels on locale change, and maybe on boot to catch OS upgrade as soon as possible. BUG=707211 Review-Url: https://codereview.chromium.org/2807213002 Cr-Commit-Position: refs/heads/master@{#464036} .../chrome/browser/DeferredStartupHandler.java | 17 ++++ .../browser/notifications/ChannelsInitializer.java | 26 ++++- .../browser/notifications/ChannelsUpdater.java | 70 +++++++++++++ .../notifications/NotificationManagerProxy.java | 4 + .../NotificationManagerProxyImpl.java | 48 +++++++++ .../upgrade/PackageReplacedBroadcastReceiver.java | 21 +++- chrome/android/java_sources.gni | 2 + .../notifications/ChannelsInitializerTest.java | 7 ++ .../browser/notifications/ChannelsUpdaterTest.java | 113 +++++++++++++++++++++ .../MockNotificationManagerProxy.java | 18 ++++ 10 files changed, 324 insertions(+), 2 deletions(-) commit a72556982dcf08c91239167f2a5cd0e1b7f50ea8 Author: lizeb <lizeb@chromium.org> Date: Wed Apr 12 08:36:35 2017 -0700 predictors: Add origin learning. This CL makes the resource predictor aware of origin requests made while loading a page. It only adds the data collection, no fetching is enabled yet, and the collection is not enabled outside of tests. Changes: - Adds a new database table to track origin requests - Adds a new protocol buffer, loading and storing logic - All redirects are now tracked as they cause origin requests - No-store resources are tracked as well, only to collect origin data. BUG=699080 Review-Url: https://codereview.chromium.org/2796783004 Cr-Commit-Position: refs/heads/master@{#464035} .../browser/predictors/resource_prefetch_common.cc | 4 +- .../browser/predictors/resource_prefetch_common.h | 4 + .../resource_prefetch_common_unittest.cc | 1 + .../predictors/resource_prefetch_predictor.cc | 277 ++++++++++++++++++--- .../predictors/resource_prefetch_predictor.h | 33 ++- .../predictors/resource_prefetch_predictor.proto | 18 ++ .../resource_prefetch_predictor_tables.cc | 114 ++++++++- .../resource_prefetch_predictor_tables.h | 32 ++- .../resource_prefetch_predictor_tables_unittest.cc | 203 ++++++++++++--- .../resource_prefetch_predictor_test_util.cc | 79 +++++- .../resource_prefetch_predictor_test_util.h | 16 ++ .../resource_prefetch_predictor_unittest.cc | 113 ++++++++- 12 files changed, 792 insertions(+), 102 deletions(-) commit 55633a0e8db901aa6ce0990c99352b5d77087d06 Author: fmalita <fmalita@chromium.org> Date: Wed Apr 12 08:34:51 2017 -0700 Cleanup CSSGradientValue 1) move member fields to subclasses, to ensure they're only used/stored by gradient types which need them 2) remove setters; instead of manipulating fields after instantiation, pass all needed params to the ctor 3) refactor the CSS parsing methods for #2: defer gradient value instantiation until all needed params are parsed 4) constify member value pointers Refactor only, no functional changes. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 BUG=614368 Review-Url: https://codereview.chromium.org/2817523002 Cr-Commit-Position: refs/heads/master@{#464034} .../WebKit/Source/core/css/CSSGradientValue.cpp | 49 ++--- .../WebKit/Source/core/css/CSSGradientValue.h | 162 +++++++++++------ .../core/css/parser/CSSPropertyParserHelpers.cpp | 202 ++++++++++----------- .../Source/core/paint/NinePieceImageGridTest.cpp | 4 +- 4 files changed, 226 insertions(+), 191 deletions(-) commit d871a9338a39d46cbb25ee6571a4e225f049bda1 Author: cjgrant <cjgrant@chromium.org> Date: Wed Apr 12 08:31:01 2017 -0700 VR: Rename ContentRectangle to UiElement UiElements show arbitrary textures now, not just content. Generalize the naming to avoid confusion. BUG=710150 Review-Url: https://codereview.chromium.org/2807293002 Cr-Commit-Position: refs/heads/master@{#464033} chrome/browser/android/vr_shell/BUILD.gn | 6 ++-- .../vr_shell/{ui_elements.cc => ui_element.cc} | 12 ++++---- .../vr_shell/{ui_elements.h => ui_element.h} | 14 ++++----- ...elements_unittest.cc => ui_element_unittest.cc} | 20 ++++++------- chrome/browser/android/vr_shell/ui_scene.cc | 35 +++++++++++----------- chrome/browser/android/vr_shell/ui_scene.h | 20 ++++++------- .../browser/android/vr_shell/ui_scene_unittest.cc | 24 +++++++-------- chrome/browser/android/vr_shell/vr_shell_gl.cc | 22 +++++++------- chrome/browser/android/vr_shell/vr_shell_gl.h | 12 ++++---- 9 files changed, 81 insertions(+), 84 deletions(-) commit 8a82f1f36590e504b12f486df6351e78ca223097 Author: yiyix <yiyix@chromium.org> Date: Wed Apr 12 08:28:12 2017 -0700 Fetch API: Add Request#cache attribute Behind the run time flag FetchRequestCache, a new attribute |cache| is added into fetch request. Cache can be set to "default", "no-store", "reload", "no-cache", "force-cache" or "only-if-cached". Please refer to https://fetch.spec.whatwg.org/#requestsNote for exact definition. Note that the implementation of cache options are not completed yet. TEST=request-init-003.sub.html BUG=453190 Review-Url: https://codereview.chromium.org/2811623002 Cr-Commit-Position: refs/heads/master@{#464032} .../api/request/request-clone.sub-expected.txt | 5 --- .../wpt/fetch/api/request/request-idl-expected.txt | 4 +-- .../api/request/request-init-003.sub-expected.txt | 7 ---- .../api/request/request-structure-expected.txt | 2 +- .../service-worker/fetch-event.https-expected.txt | 4 +-- ...l-interface-listing-service-worker-expected.txt | 1 + ...l-interface-listing-service-worker-expected.txt | 1 + ...interface-listing-dedicated-worker-expected.txt | 1 + .../global-interface-listing-expected.txt | 1 + ...al-interface-listing-shared-worker-expected.txt | 1 + .../Source/modules/fetch/FetchRequestData.cpp | 3 ++ .../WebKit/Source/modules/fetch/FetchRequestData.h | 8 +++++ .../WebKit/Source/modules/fetch/Request.cpp | 40 +++++++++++++++++++--- third_party/WebKit/Source/modules/fetch/Request.h | 1 + .../WebKit/Source/modules/fetch/Request.idl | 3 ++ .../WebKit/Source/modules/fetch/RequestInit.cpp | 3 ++ .../WebKit/Source/modules/fetch/RequestInit.h | 1 + .../Source/platform/RuntimeEnabledFeatures.json5 | 4 +++ .../platform/exported/WebServiceWorkerRequest.cpp | 12 +++++++ third_party/WebKit/public/platform/WebURLRequest.h | 9 +++++ .../serviceworker/WebServiceWorkerRequest.h | 3 ++ 21 files changed, 92 insertions(+), 22 deletions(-) commit 80e3eb904ef28e2491b831099597fc05347845ae Author: isandrk <isandrk@chromium.org> Date: Wed Apr 12 08:22:14 2017 -0700 PS - Remove Clipboard Read permission from extensions in Public Sessions (except for whitelisted ones) In Public Sessions, apps and extensions are force-installed by admin policy so the user does not get a chance to review the permissions for these apps. This is not acceptable from a security standpoint, so we remove ClipboardRead permission from them (except for whitelisted ones - eg. remote desktop clients). This forceful removal of permission is safe since the clipboard pasting code checks for this permission before doing the paste. TEST= unit_tests --gtest_filter=DeviceLocalAccountManagementPolicyProviderTest.IsWhitelisted unit_tests --gtest_filter=PermissionsUpdaterDelegateChromeOSTest.* unit_tests --gtest_filter=PermissionsUpdaterTest.Delegate BUG=707864 Review-Url: https://codereview.chromium.org/2794803003 Cr-Commit-Position: refs/heads/master@{#464031} chrome/browser/chromeos/BUILD.gn | 3 + ...ice_local_account_management_policy_provider.cc | 8 +- ...vice_local_account_management_policy_provider.h | 5 ++ ..._account_management_policy_provider_unittest.cc | 13 +++ .../permissions_updater_delegate_chromeos.cc | 42 ++++++++++ .../permissions_updater_delegate_chromeos.h | 39 +++++++++ ...rmissions_updater_delegate_chromeos_unittest.cc | 98 ++++++++++++++++++++++ .../login/users/chrome_user_manager_impl.cc | 10 +++ chrome/browser/extensions/permissions_updater.cc | 15 +++- chrome/browser/extensions/permissions_updater.h | 17 ++++ .../extensions/permissions_updater_unittest.cc | 50 +++++++++++ 11 files changed, 298 insertions(+), 2 deletions(-) commit 49766ea841fd7c75647e4ffb0659dc344d8d8947 Author: dgn <dgn@chromium.org> Date: Wed Apr 12 08:20:34 2017 -0700 [Suggestions] Remove access point to dedicated pref screen BUG=706384,710636 Review-Url: https://codereview.chromium.org/2810913006 Cr-Commit-Position: refs/heads/master@{#464030} chrome/android/java/res/xml/main_preferences.xml | 4 ---- .../browser/ntp/ContentSuggestionsNotificationHelper.java | 10 ---------- .../browser/preferences/ContentSuggestionsPreferences.java | 1 + .../chromium/chrome/browser/preferences/MainPreferences.java | 8 -------- 4 files changed, 1 insertion(+), 22 deletions(-) commit 3b0155e9b6ab3719ce1d1fda5cdb5fb9d0e486ec Author: sdefresne <sdefresne@chromium.org> Date: Wed Apr 12 08:18:53 2017 -0700 [ios] Change WebStateListObserverBridge to use weak reference. For consistency with the other observer bridges, change the API of WebStateListObserverBridge to *not* own the Objective-C observer, and change TabModel/WebStateListFastEnumerationHelper to respect the new API. Note: the other client of WebStateListObserverBridge used the API as if the id<WebStateListObserving> was not owned, thus leaked both objects. No code change is required there. BUG=709984 Review-Url: https://codereview.chromium.org/2809543003 Cr-Commit-Position: refs/heads/master@{#464029} ios/chrome/browser/tabs/tab_model.mm | 53 +++++++++--- .../web_state_list_fast_enumeration_helper.mm | 93 +++++++--------------- .../web_state_list_observer_bridge.h | 5 +- 3 files changed, 74 insertions(+), 77 deletions(-) commit b55da6367aadc5c1e7c0c5769f6d32fef5249fa0 Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org> Date: Wed Apr 12 13:52:54 2017 +0000 Roll src/third_party/pdfium/ d776c9764..12c74ac6e (1 commit) https://pdfium.googlesource.com/pdfium.git/+log/d776c9764c7b..12c74ac6ee2d $ git log d776c9764..12c74ac6e --date=short --no-merges --format='%ad %ae %s' 2017-04-12 dsinclair Minor text change in README. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Iac3cf0a87742d451792a110b6b2f42a7b164d000 Reviewed-on: https://chromium-review.googlesource.com/475076 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#464028} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a6f580ee29385647f86e82efb9ab1192c6b0f849 Author: hans <hans@chromium.org> Date: Wed Apr 12 08:16:27 2017 -0700 Roll clang 298539:299960. This includes r299782 which allows for using _interlockedbittestandset without including intrin.h, and a configuration change which means Clang no longer implicitly passes -Wl,--build-id to the linker by default. BUG=709521,622775,708769 Review-Url: https://codereview.chromium.org/2816593003 Cr-Commit-Position: refs/heads/master@{#464027} tools/clang/scripts/update.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 457dcdd09c5fe44b8eb75bcdb0b7b8beab158b49 Author: mathp <mathp@chromium.org> Date: Wed Apr 12 08:14:55 2017 -0700 [Payments] Change how the dialog gets destroyed. The views need to go first, then the controllers. This is because some views may have pointers/delegates back to their controllers. BUG=710127 TEST=a few more browser_tests Review-Url: https://codereview.chromium.org/2810193003 Cr-Commit-Position: refs/heads/master@{#464026} ...edit_card_editor_view_controller_browsertest.cc | 13 +++ .../views/payments/payment_request_browsertest.cc | 21 +++++ .../views/payments/payment_request_dialog_view.cc | 95 ++++++++++++---------- .../views/payments/payment_request_dialog_view.h | 4 +- chrome/browser/ui/views/payments/view_stack.h | 6 +- 5 files changed, 90 insertions(+), 49 deletions(-) commit 78a049660074003b8e1e602b0e7783ca7f1f4ee0 Author: altimin <altimin@chromium.org> Date: Wed Apr 12 08:08:03 2017 -0700 [scheduler] Move some task types to suspendable task runner. Move several safe-looking task types to suspendable task runner. More task types will be moved to suspendable task runner, but we'll start with this set and will monitor any problems (there were some perfbot failures when all task queues were moved to suspendable task runner). R=haraken@chromium.org CC=skyostil@chromium.org BUG=702160 Review-Url: https://codereview.chromium.org/2808273003 Cr-Commit-Position: refs/heads/master@{#464025} .../WebKit/Source/core/dom/TaskRunnerHelper.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) commit 5bc8d44f3ab226674d0dd2c52ef631d6d52dc464 Author: raphael.kubo.da.costa <raphael.kubo.da.costa@intel.com> Date: Wed Apr 12 08:06:27 2017 -0700 Import XMLHttpRequest wpt tests. Some Fetch API tests require bits from the /XMLHttpRequest directory. Some of the tests are also required for correctly testing behavior after changes to the Fetch and XHR specs. BUG=687155,705490 R=falken@chromium.org,tyoshino@chromium.org,yhirano@chromium.org Review-Url: https://codereview.chromium.org/2808403003 Cr-Commit-Position: refs/heads/master@{#464024} third_party/WebKit/LayoutTests/W3CImportExpectations | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 08f973975155004f8a9bc6887f6e9551cedbac1d Author: estevenson <estevenson@chromium.org> Date: Wed Apr 12 08:04:53 2017 -0700 Add resource_sizes diffs to diagnose_apk_bloat.py. This CL adds the ability to show the differences in resource_sizes.py metrics using dianose_apk_bloat.py. It also includes a few other updates: * Simplfy output and write diff output to file * Generate and save .size files (and save .so files for Disassemble()) * Be nicer by restoring user branches after script runs BUG=710076 Review-Url: https://codereview.chromium.org/2810813003 Cr-Commit-Position: refs/heads/master@{#464023} tools/binary_size/README.md | 4 +- tools/binary_size/diagnose_apk_bloat.py | 270 +++++++++++++++++++++++++------- 2 files changed, 212 insertions(+), 62 deletions(-) commit 490d8cdd48f1813962f5549217b737642ccbfa3e Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Wed Apr 12 13:46:08 2017 +0000 Roll src/third_party/skia/ 7cad9897d..ac796f880 (2 commits) https://skia.googlesource.com/skia.git/+log/7cad9897d413..ac796f880f0a $ git log 7cad9897d..ac796f880 --date=short --no-merges --format='%ad %ae %s' 2017-04-12 msarett Override setDrawFilter() in SkColorSpaceXformCanvas 2017-04-12 kjlubick Re-align tests in recipes with the names of reality Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I07369ef3379d28db90fe27ea6cc38d516899b7c7 Reviewed-on: https://chromium-review.googlesource.com/475093 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#464022} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Updated tag 'tree_truth' (was db6866c4fe34)